feat: dto with association #583
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @graemerocher Could you please check this draft PR and let me know if you think this is the right direction to go. Sergio del Amo |
graemerocher
reviewed
Jun 8, 2020
| @@ -489,6 +508,18 @@ private boolean attemptProjection(@NonNull MethodMatchContext matchContext, @Non | |||
| if (pp == null) { | |||
| pp = entity.getIdOrVersionPropertyByName(propertyName); | |||
| } | |||
| SourcePersistentEntity association = null; | |||
| if (pp == null && propertyName.endsWith(DtoJoinPathsParser.CAPITALIZED_ID)) { | |||
There was a problem hiding this comment.
Seems an arbitrary limitation this endsWith check. I think entity.getPath(propertyName) should be called since if that returns a path you have a query on any property of the association.
...processor/src/main/java/io/micronaut/data/processor/visitors/finders/DtoJoinPathsParser.java
Outdated
Show resolved
Hide resolved
| Set<String> paths = new HashSet<>(); | ||
| for (PropertyElement propertyElement : dto.getBeanProperties()) { | ||
| final String name = propertyElement.getName(); | ||
| if (name.endsWith(CAPITALIZED_ID)) { |
There was a problem hiding this comment.
Also limiting the capability to just properties ending with Id seems odd
| @@ -101,7 +112,7 @@ public Object read(@NonNull S object, @NonNull Argument<?> argument) { | |||
| * @param property THe property | |||
| * @return The result | |||
| */ | |||
| public @Nullable Object read(@NonNull S resultSet, @NonNull RuntimePersistentProperty<T> property) { | |||
| public @Nullable Object read(@NonNull S resultSet, @NonNull RuntimePersistentProperty<?> property) { | |||
There was a problem hiding this comment.
Why is this change necessary? If the association is being queried we probably should instantiate another DTOMapper with the appropriate entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.